amppackager icon indicating copy to clipboard operation
amppackager copied to clipboard

Add a GitHub PR check for transformers/

Open twifkak opened this issue 6 years ago • 3 comments

Ensure that no PR includes a change to transformers/ unless it is a sync from Google (e.g. #309).

(Ideally, we'll make GitHub the source of truth for transformers/ eventually, but that's a harder project.)

twifkak avatar May 30 '19 21:05 twifkak

Changes in github to transformers is supported. But the author information may be lost (I'd have to double check the configuration on the sync script).

alin04 avatar May 30 '19 21:05 alin04

Ah, yes, the PR check should block merging the PR, not mailing it out. The wacky PR-to-Google, Google-to-GitHub flow should be supported, still.

twifkak avatar May 30 '19 22:05 twifkak

A small amount of research to be done here, but should be pretty quick. A couple of examples to follow:

  • https://github.com/qawolf/actions-test/blob/master/.github/actions/create-status-check/index.js, per https://github.community/t/github-actions-as-status-checks/16666/5
  • https://github.com/mitchheddles/github-action-status-check, per https://www.google.com/search?q=github+actions+status+checks

Alternatively, I think we could host our own server on the free tier of some cloud? See https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks and https://developer.github.com/v3/guides/building-a-ci-server/. But this seems like unnecessary complexity.

twifkak avatar Jun 05 '20 19:06 twifkak