PCG icon indicating copy to clipboard operation
PCG copied to clipboard

Reimplement character sequences into a character matrix.

Open recursion-ninja opened this issue 7 years ago • 2 comments

Currently character sequences are stored on the nodes of the phylogenetic forest. This make column-wise analysis unwieldy. We should instead store the character sequences as rows in a "character matrix" which is separate from the graph topology. This will make column-wise operations (required for network analysis and metadata summaries) more efficient and less unwieldy. Will also make extracting single characters from the phylogenetic forest much easier.

The representation will likely be Vector (Character Sequence u v w x y z), with the vector indices corresponding to the indices of the reference vector of the topological representation.

recursion-ninja avatar Oct 11 '18 04:10 recursion-ninja

We should explore generalizing the postorder and preorder passes into a continuation-passing-style memoization so that multiple pass logic can be combined into a single "fold."

recursion-ninja avatar Dec 07 '18 15:12 recursion-ninja

When we do this consider whether it is possible to use Unboxed Vectors either for the character matrix itself or for the CharacterSequences (I think the latter is more likely to make sense).

Boarders avatar Aug 26 '19 21:08 Boarders