Andrew Casey

> The generic method looks prettier! Can this issue be fixed in runtime? https://github.com/dotnet/runtime/blob/cd7e4cacce3b47a2560bc9ec746f0825a43f99d7/src/libraries/Microsoft.Extensions.Logging.Abstractions/src/LoggerFactoryExtensions.cs https://github.com/dotnet/runtime/issues/48473 😢

I don't suppose you have any numbers indicating how many instantiations this saves? The change looks unobjectionable and is probably acceptable as a speculative improvement, but my intuition is that...

CI is failing because there needs to be a change to the PublicAPI.Unshipped.txt listing the new APIs. The easiest way to add those entries is with the code fix in...

@danmoseley Did you mean to tag @JamesNK?

@davhdavh I find tratcher's argument, that throwing makes logical sense and the caller should do more to suppress the effects, persuasive and I'm not sure I understand the distinction you're...

Closing without prejudice - feel free to create a new one if you have new data or arguments.

@JanEggers Can you please provide a small repro program demonstrating the issue? Probably, this would look like a single test followed by the cleanup you were expecting to free the...

How does it interact with `RequireLowercase` and `RequireUppercase`? (There's probably a good answer, but we don't want users to have to think about this.) The same thing can be accomplished...

[My previous response was on behalf of the API review group - this is just me] > I already answered that question above. That's fair, you did. However, that's not...

@hamidrezahy If you're using VS or the C# Dev Kit in VS Code, there should be a code fix offering to add those members to the public API. Otherwise, you'll...