Taras Vozniuk

Results 64 comments of Taras Vozniuk

@wipfli: correct, same ones fail. does the full bench suite runs fine for you?

@wipfli: the comments should be resolved. Let me know if there is anything else needed here. The documentation of map.setStyle with inline example renders as:

@HarelM: it seems based on https://github.com/maplibre/maplibre-gl-js/blob/964b2a7405a7508c3cd4be4eb1da7f03a7a14f67/src/style/style.ts#L80-L82 that diffing of sprites / glyphs were expected to be added at some point. We should look into that in a follow-up PR to...

@wipfli: I have resolved the comments the fixed the doc redundancy you mentioned in the following way: 1. [map.setStyle()](https://maplibre.org/maplibre-gl-js-docs/api/map/#map#setstyle) documentation contains a short brief description about StylePatchFunction and links to...

> @wipfli asked me to review this, sorry for the extra effort and questions :-) no worries, thanks a lot for the review, I will try to address all of...

> Since we are working on version 3.x now, if this need to introduce a breaking change, now is the time :-) Overall, I think this is a very nice...

@HarelM, @mbelt, @wipfli: Before getting this merged, I wanted to get your thoughts on possible alternative. There are 2 details of existing exposed stylePatch that I see: ``` stylePatch?: (...

@wipfli, @HarelM: thanks, in this case let me make another PR based on this and we can see how these two approaches compare

closed in favour of https://github.com/maplibre/maplibre-gl-js/pull/1632