gun icon indicating copy to clipboard operation
gun copied to clipboard

add test for content addressing

Open thrownness opened this issue 5 years ago • 7 comments
trafficstars

I think this is correct, but let me know!

But the key thing is that this needs to be tested on webkit browsers. Webkit powers all browsers on iOS (and Safari desktop), so it's a huge market.

thrownness avatar May 24 '20 14:05 thrownness

@thrownness you can see that travis build is failing TypeError: Cannot read property 'get' of undefined at SEA.work.name (/home/travis/build/amark/gun/test/sea/sea.js:44:13) at Object.SEA.work.SEA.work (/home/travis/build/amark/gun/sea.js:278:22) 1) Content Addressing

var gun is undefined by default, you need to instantiate it. see other tests.

sirpy avatar May 24 '20 18:05 sirpy

I'm now seeing Warning: reusing same fs store and options as 1st., but it appears that the test works nonetheless. It throws and then there's a checkmark in front of the test.

thrownness avatar May 25 '20 17:05 thrownness

Are any of these tests able to be run in the browser? Or are these only for Node?

thrownness avatar May 25 '20 17:05 thrownness

just node. not aware of browser tests maybe @amark can tell more. there should be a way to run these tests also on a browser

sirpy avatar May 25 '20 18:05 sirpy

https://mochajs.org/#running-mocha-in-the-browser

There might already be an html file with this setup. It just needs to be run on Safari too

thrownness avatar May 26 '20 20:05 thrownness

yaaay!

tests/mocha.html I check in browser before publishing, but be nice to automate across all browsers.

ut-oh, test is failing! I'll need to look into that? I haven't peeked at the code/test yet.

👏 for more tests tho! This is how progress happens, painfully detailed, but it is laying concrete foundation & building up layer by layer at a time until the world is changed forever because they take the bedrock to be granted. Making sure our stuff actually works at each step. :)

amark avatar Jun 03 '20 20:06 amark

@thrownness this is the thing that is breaking iOS/webkit/safari right?

amark avatar Jun 15 '20 03:06 amark