amxmodx icon indicating copy to clipboard operation
amxmodx copied to clipboard

amx_debug '2' ignore missing debug

Open UnrealKaraulov opened this issue 3 years ago • 4 comments

Please, if no debug info, don't crash plugins, just write error and skip debug info.

Description:

Many plugins like extended ban systems (fresh bans, etc) or antihacks (aim detectors, etc) compiled without debug for protect source code from hackers. At this moment, if activate amx_debug 2 all plugins without debug info stop working.

After the merge, we will just write information about the missing of debug option and the plugin continues work without any issues. (Also it can be useful for debug this plugins with Performance Monitor even without debug info)

UnrealKaraulov avatar Dec 07 '21 04:12 UnrealKaraulov

I'm confused, what crash is this fixing?

dvander avatar Dec 07 '21 04:12 dvander

@dvander

Before this fix. If we enabled amx_debug 2, all plugins compiled without debug option - stopped with error. After this fix. If we enabled amx_debug 2, all plugins compiled without debug option - continue works, but without debug flag.

I hope now I wrote it easier and clearer :)

UnrealKaraulov avatar Dec 07 '21 05:12 UnrealKaraulov

@dvander i think latest commit in this PR is really latest.

Now if user forced set debug in plugins.ini - default behavior. If user set amx_debug 2, then skip debug if no debug info found.

Do You think this is more better or was the previous version is better?

UnrealKaraulov avatar Dec 07 '21 05:12 UnrealKaraulov

Any questions?

UnrealKaraulov avatar Feb 02 '22 16:02 UnrealKaraulov

@dvander @Arkshine ping

wopox1337 avatar Dec 24 '22 10:12 wopox1337

@dvander @Arkshine америкосы

UnrealKaraulov avatar Sep 07 '23 08:09 UnrealKaraulov