allennlp icon indicating copy to clipboard operation
allennlp copied to clipboard

Published 20 hours ago • verified publisher icon allenai

Added for saving git info

Open Shreyz-max opened this issue 3 years ago • 9 comments

Change proposed in this pull request: Saving git repo infos in meta class along with metadata of model archives after going through #4862 issue

Before submitting

  • [x] I've read and followed all steps in the Making a pull request section of the CONTRIBUTING docs.
  • [x] I've updated or added any relevant docstrings following the syntax described in the Writing docstrings section of the CONTRIBUTING docs.
  • [ ] If this PR fixes a bug, I've added a test that will fail without my fix.
  • [ ] If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • [ ] All GitHub Actions jobs for my pull request have passed.
  • [ ] codecov/patch reports high test coverage (at least 90%). You can find this under the "Actions" tab of the pull request once the other checks have finished.

Shreyz-max avatar Aug 13 '22 08:08 Shreyz-max

Looks good. Can you also add a changelog entry?

dirkgr avatar Aug 17 '22 22:08 dirkgr

Looks good. Can you also add a changeling entry?

Do you mean adding it into the changelog?

Shreyz-max avatar Aug 18 '22 05:08 Shreyz-max

Yes, sorry for the typo. Autocorrect, am I right? 😅

dirkgr avatar Aug 18 '22 18:08 dirkgr

Haha, happens to the best of us.

Shreyz-max avatar Aug 19 '22 09:08 Shreyz-max

Hey @dirkgr this is my first time working on open source and I think by mistake I disabled auto-merge. Also, I have no clue why the tests are not passing. Could you give me some ideas on where and how to start? It will be really helpful.

Shreyz-max avatar Aug 20 '22 10:08 Shreyz-max

I think auto-merge automatically disables itself when you make a change. Otherwise anyone could push to the branch and it would get merged. It's a safety feature in GitHub.

Let's see if those tests are even still failing.

dirkgr avatar Aug 24 '22 00:08 dirkgr

I'm afraid this is a real test failure. The tests now seem to require your git repo to be in a very defined state. We can't have that. It breaks our own tests, and it'll certainly break the tests that @h-vetinari runs in conda-forge.

dirkgr avatar Aug 24 '22 22:08 dirkgr

So what should be done next?

Shreyz-max avatar Aug 25 '22 04:08 Shreyz-max

Look at the error and decide on a path to fix it. It looks to me like it's trying to determine the name of the current branch. What should happen if there isn't a current branch? What should happen if the code is run outside of a git repository?

dirkgr avatar Sep 07 '22 00:09 dirkgr