typescript-strict-plugin icon indicating copy to clipboard operation
typescript-strict-plugin copied to clipboard

Feature request: Nx.dev compatibility

Open binary64 opened this issue 3 years ago • 7 comments

Hi I love the idea of your plugin. I'm trying to get it to work in my monorepo, which uses Nx.dev.

Here's how you can get a repo locally to test with:

npm i -g yarn && \
rm -rf ~/nx-demo && \
cd ~/ && \
npx create-nx-workspace nx-demo --packageManager=yarn --style=less --nx-cloud=false --interactive=false --preset=empty --linter=eslint && \
cd nx-demo

I currently get this error

Error: Command failed with exit code 1: tsc --showConfig
error TS5081: Cannot find a tsconfig.json file at the current directory: C:/p/nx_test.

Many thanks!

binary64 avatar Feb 28 '22 20:02 binary64

Hi, you can quickly fix it either by renaming tsconfig.base.json to tsconfig.json, or by adding new tsconfig.json with following body:

{
  "extends": "./tsconfig.base.json",
}

kamkry avatar Mar 01 '22 10:03 kamkry

I tried both of your suggests, but I run node_modules/.bin/update-strict-comments I get:

Project does not contain any strict files.

Any ideas? It's a pretty plain Nx repo

binary64 avatar Mar 02 '22 12:03 binary64

Does your project include any typescript files? That error is thrown only when either there's no TS files or every TS file is ignored with //@ts-strict-ignore comment

kamkry avatar Mar 02 '22 15:03 kamkry

Yes, I only have mostly .tsx and .ts files. And a couple of .js files.

I don't have any @ts-strict-ignore's

binary64 avatar Mar 04 '22 00:03 binary64

@binary64 I currently have the same issue, have you found a solution yet?

anatter avatar Jan 02 '23 08:01 anatter

Same here. Looks like this plugin lacks support for entry points for projects with multiple tsconfig files.

TheBox193 avatar Apr 27 '23 06:04 TheBox193