json-logic-kmp icon indicating copy to clipboard operation
json-logic-kmp copied to clipboard

Published 20 hours ago • verified publisher icon allegro

Release 1.1.7 broken our Android build.

Open idunnololz opened this issue 2 years ago • 1 comments

Updating to 1.1.7 broke our release build for our Android app. This appears to involve R8 + kotlinx-datetime which was added in this commit: https://github.com/allegro/json-logic-kmp/pull/120/commits/9f6027089ab3b049c1abaa0b8e8d6437e80e2a8f.

It looks like kotlinx-datetime uses kotlinx.serialization and kotlinx.serialization requires some specific proguard rules to work. See https://github.com/Kotlin/kotlinx.serialization#android.

The easiest way to reproduce this is to create a new Android app. Ensure Android Gradle Plugin in 8 or higher. Add json-logic-kmp v1.1.7 and then do a release build.

idunnololz avatar Jul 31 '23 18:07 idunnololz

Thanks for the report! Would you like to propose a change in the library that fixes that issue in the PR? We'll be happy to review and release it. I added you as a collaborator.

PaulinaSadowskaAllegro avatar Oct 06 '23 13:10 PaulinaSadowskaAllegro