algrid
algrid
Everything looks good to me at this point, except one thing: are the changes to the meson files ok? The old removed sha1_dep was treated a bit differently. Maybe someone...
@HaplessIdiot you should be able to update your old PR. Just push/force push your new changes to your old branch.
I can’t say if this change does what it’s supposed to do really, need other reviewers opinion.
> on my TV that makes it go to 1080p60hz so it has some wierdness with 4k30hz tvs If this code is unable to find any mode >75hz it goes...
I’m not sure about this. With the old code it was clear that only one config will be active. With this change I’m not sure what will happen if more...
Do we really need to switch to memcpy calls while we keep the loops anyway? Maybe it’s possible to modify the loops somehow to make CodeQL more happy? Like iterate...
There shouldn't be anything to flush if `NewOutputPending` is false. That if the logic has no bugs. Honestly, it looks like that flag was introduced exactly to prevent too frequent...
@metux yep, and [here](https://github.com/X11Libre/xserver/blob/5c3ce08b0e8082a9307e46710f1f2dec4d2bd534/os/io.c#L958) is the relevant code where we start waiting for the socket to become writable (when it becomes stuck). Maybe for now just let your and @stefan11111...
Apparently the value was supposed to be chosen as the most suitable for a given architecture. But then someone decided (in fb.h) that it can only be 4. I wonder...
Why do you think it's better? The old version looks more compact.