instantsearch-ios icon indicating copy to clipboard operation
instantsearch-ios copied to clipboard

Published 20 hours ago • verified publisher icon algolia

Breaking changes in dependencies

Open squarefrog opened this issue 1 year ago • 9 comments

Describe the bug 🐛 Originally reported in algoliasearch-client-swift but it feels more relevant here. Feel free to close that issue if you like.

One of instantsearch-ios dependencies has introduced a breaking change that prevents instantsearch-ios from building on iOS 15. It bumps the minimum target to iOS 14, but instantsearch-ios has a minimum target of iOS 9. This prevents compilation, even if you are targeting a higher version than iOS 9.

To Reproduce 🔍 Steps to reproduce the behavior:

  1. Clone this project
  2. Open the Example Xcode project
  3. Wait for package resolution
  4. Attempt to build

Expected behavior 💭 Example project should build.

Screenshots 🖥 Screenshot 2024-02-02 at 15 42 58

Environment:

  • OS: iOS
  • Version 15+
  • Xcode 15

Additional context You can work around this issue by manually adding https://github.com/algolia/algoliasearch-client-swift to your project, and setting the resolution rule to be exact: 8.19.0

Screenshot 2024-02-02 at 15 44 54

squarefrog avatar Feb 02 '24 15:02 squarefrog

Hi @squarefrog , That's indeed an unexpected breaking change. Thanks for flagging this! We're preparing an update for InstantSearch iOS to fix it. Expect a release soon. Meanwhile, your workaround with the explicit client version setting is a good interim solution.

VladislavFitz avatar Feb 02 '24 16:02 VladislavFitz

Sounds good!

squarefrog avatar Feb 02 '24 16:02 squarefrog

Hi @VladislavFitz when would the fix go live? Our CI workflows fail with the above-mentioned error

r3econ avatar Feb 19 '24 09:02 r3econ

hi is there a fix for this yet?

RebinX1 avatar Mar 12 '24 17:03 RebinX1

Any update for this?

Ma7m0udalaa avatar Mar 20 '24 06:03 Ma7m0udalaa

Also waiting on a fix for this

salami avatar Mar 25 '24 18:03 salami

Any update? We'd love to have it fixed :)

r3econ avatar Apr 10 '24 10:04 r3econ

Any update on this?

akshaaatt avatar May 08 '24 11:05 akshaaatt

@nickvlku any chance having this fixed? 🥲

r3econ avatar May 10 '24 14:05 r3econ

We're preparing an update for InstantSearch iOS to fix it. Expect a release soon.

For when can we expect this release? We might have different definitions of "soon" 😒

NicolasBrunnerSRF avatar Jul 24 '24 12:07 NicolasBrunnerSRF

@NicolasBrunnerSRF have you tried updating instantsearch-ios to v7.26.2? It was released a few ago and realigned supported platform versions with the API client library.

dhayab avatar Jul 24 '24 12:07 dhayab

As far as I’m concerned 7.26.2 does indeed fix this and the issue should be closed.

squarefrog avatar Jul 24 '24 13:07 squarefrog

@dhayab I can also confirm that v7.26.2 does fix the issue 🥳 Thanks for the update!

NicolasBrunnerSRF avatar Jul 24 '24 13:07 NicolasBrunnerSRF