api-clients-automation icon indicating copy to clipboard operation
api-clients-automation copied to clipboard

Published 20 hours ago • verified publisher icon algolia

feat(clients): add recommend to algoliasearch

Open shortcuts opened this issue 1 year ago • 2 comments

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

related to https://github.com/algolia/api-clients-automation/pull/2834

shortcuts avatar Mar 12 '24 18:03 shortcuts

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch. You can still access the code generated on main via this commit.

algolia-bot avatar Mar 12 '24 18:03 algolia-bot

🚀 Deployed on https://6679347702ce937c179bf15d--api-clients-automation.netlify.app

github-actions[bot] avatar Mar 12 '24 19:03 github-actions[bot]

the generated comment is the part that should interest you @Haroenv @aymeric-giraudet https://github.com/algolia/api-clients-automation/pull/2860#issuecomment-1992317211

shortcuts avatar Jun 20 '24 13:06 shortcuts

I agree with the idea of this PR, but I don't know this code base well enough to give a real assessment on whether it's implemented correctly

Thanks for the review :) it was mostly to let you see the progress of it, in term of implementation it will end up with https://667930f9faf0e278fa0f78b2--api-clients-automation.netlify.app/specs/recommend#tag/recommendations/operation/getRecommendations in the lite client, exactly with the same signature

(and @aymeric-giraudet is working on providing a legacy signature support too)

shortcuts avatar Jun 24 '24 08:06 shortcuts