Alex Murray

Results 112 comments of Alex Murray

@AdnanHodzic actually that output shows the interface is *not* connected - if it was it would look like ``` cpu-control auto-cpufreq:cpu-control :cpu-control manual ``` Can you please try running: ```...

@AdnanHodzic I've just approved the GitHub actions to run, once they are complete then one of the snapd maintainers can choose to merge it (unfortunately I don't have that permission).

@ernestl any chance we can target this for 2.64? Also @pedronis @zyga @bboozzoo any chance you could weigh in on my question above^^^ https://github.com/snapcore/snapd/pull/13354#issuecomment-2011246767 re the failing spread tests?

@ifurther this requires more reviews from members of the snapd team.

Would it be preferable to use the snap of golangci-lint instead? I maintain this currently myself but would be happy to transfer it to Canonical and maintain it there instead...

From what I can see the udisks2 daemon uses libpolkit (https://github.com/storaged-project/udisks/blob/master/src/udisksdaemon.c#L373), and this in turn *does* specify the name "org.freedesktop.PolicyKit1" https://gitlab.freedesktop.org/polkit/polkit/-/blob/master/src/polkit/polkitauthority.c#L320 - so I do *not* think this change to...

Since only one application can register objects at a given path on dbus, the removal of the `name` part for PolicyKit is not likely to be problematic - however if...

Closing and reopening to retrigger actions checks since `unit-tests (latest/stable, normal)` seems to have unexpectedly failed.

> I'm unsure about the spread tests, because it seems we are creating a mega-test (`tests/main/snapd-snap`) to basically test that the snap package of snapd is sane, but do we...

@mardy @pedronis thanks for the review comments - I believe I have now addressed all of them - can you please take another look? Thanks.