bloom-filter-scala

bloom-filter-scala copied to clipboard

Hi, currently the BloomFilter and its buffer are not serializable, can this be added? same goes for kryo support, can be added with an optional dependency (I've actually already implemented this as part of my spark application)

another related issue, the provided to/from stream methods work one long at a time. haven't really benchmarked this but my intuition is that this is slowwwww. I suggest modify the current methods or add new ones that takes/allocates a buffer and leverage unsafe's ability to copy memory ranges (spark tungsten's style)

will you be willing to accept pull requests?

thanks, Eyal.

Hi Eyal,

Thank you for the suggestions! Yes, definitely! Pull requests are welcome!

@alexandrnikitin, I'm happy I could assist with the Java serialization support😎 I'd like to move on to kryo support, do you prefer the serializers as part of the core bloom filters library with an optional dependency on kryo, or an additional sub project with a strong dependency on kryo?

Great! I think a sub project for kryo is a better option.

👍

On Mar 21, 2017 8:22 PM, "Alexandr Nikitin" [email protected] wrote:

Great! I think a sub project for kryo is a better option.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/alexandrnikitin/bloom-filter-scala/issues/23#issuecomment-288173144, or mute the thread https://github.com/notifications/unsubscribe-auth/ABFFOajEkmLQkzMZvP3D7UrXk6XPTFnbks5roBVpgaJpZM4MFaX0 .

have you added kryo support to this bloomfilter??/

Not yet. As I see @eyalfa has done some work in the fork's branch https://github.com/eyalfa/bloom-filter-scala/commits/kryo_support @kdsandip Would you have time to review and continue the work?