ReadabiliPy icon indicating copy to clipboard operation
ReadabiliPy copied to clipboard

Error in Readability.js ?

Open fernand0 opened this issue 1 year ago • 2 comments

I'm using readabilitpy 0.2.0 and I've found what I think is an error. In file Readability.js, in line 1227, there is the line:

             values[name] = content.trim();

But content can be empty and it will produce an error. I've solved it in line 1219, adding a check for content:

       if (elementProperty && content) {

But I'm not sure if it is the correct way to deal with the issue. I can send a PR if this is ok.

Best regards, thank you and keep up the good work!

fernand0 avatar Sep 29 '24 11:09 fernand0

Hi @fernand0. This project isn't being actively maintained. If you'd like to submit a PR, I'm happy to review it though.

jemrobinson avatar Sep 30 '24 08:09 jemrobinson

Hello,

don't worry, it seems to be a problem of Mozilla readability.js (which your project seems to be installing using npm) and it seems to be solved now.

Thanks!

fernand0 avatar Oct 07 '24 11:10 fernand0