base64 icon indicating copy to clipboard operation
base64 copied to clipboard

Published 20 hours ago • verified publisher icon aklomp

Benchmark: now compiles on Windows

Open zenden2k opened this issue 10 years ago • 5 comments

Tested on MSVC and Mingw

zenden2k avatar Sep 14 '15 08:09 zenden2k

But before we can even use the Windows code, we need a build system that works under Windows, right?

aklomp avatar Sep 14 '15 20:09 aklomp

Please don't take my criticism the wrong way, it's all done with the best intentions.

aklomp avatar Sep 14 '15 20:09 aklomp

Hey, to move this issue forward a little bit, I rewrote your pull request with inclusion of my comments in the branch zenden-new-branch-2. Does this still work correctly on Windows? Any additions/comments?

aklomp avatar Sep 22 '15 21:09 aklomp

Sorry i had a really hard week... did not have time at all.

Compilation of the new branch fails.

#define UNIX_EPOCH 116444736000000000ULL;
  • extra ';'
ts->tv_nsec = ((current_time.QuadPart - UNIX_EPOCH) % 1e7) * 100;
  • error C2297: '%' : illegal, right operand has type 'double'

After fixing that everything works just fine.

zenden2k avatar Sep 23 '15 04:09 zenden2k

Thanks for testing, should be fixed now. I also learnt that exponential constants have type double and not int like regular numeric constants.

aklomp avatar Sep 23 '15 06:09 aklomp

Thanks everyone for your patience. I felt comfortable working on this patch and merging it now that our CI supports Windows and MinGW (#127). The final commits have changed a bit since this PR, but I couldn't have done it without it. :heart:

aklomp avatar Jan 09 '24 15:01 aklomp