react-slick icon indicating copy to clipboard operation
react-slick copied to clipboard

Setting rows property to < 1 or null crashes the app and tab.

Open blwsh opened this issue 7 years ago • 16 comments

The app will crash if you set the sliders row property to anything < 1 or null. The row property sometimes needs to be set to 0 so slick doesn't wrap your slide content in a pointless div according to a resolved issue on the slick github repo.

To replicate just add rows: 0 to your settings object.

blwsh avatar Jun 01 '18 13:06 blwsh

Same here. I've tried to use rows: 0 in order to avoid the regression caused by adding an extra row div. The page crashes.

silicakes avatar Jul 01 '18 10:07 silicakes

Can confirm, happening for me as well - latest stable version.

GioLogist avatar Jul 24 '18 22:07 GioLogist

Can confirm too, happens on the latest stable version, it's acually unusable for me at this point because of it.

edzjins avatar Jul 31 '18 11:07 edzjins

Same here. Guys is there some way to fix that behavior?

matenka-andrii avatar Oct 23 '18 15:10 matenka-andrii

Confirm this issue is still occurring. Has anyone found a fix for this yet? Having a redundant div is driving me bonkers.

webdevpchoi avatar Mar 04 '19 02:03 webdevpchoi

Confirm this issue is still occurring

LuisPerez94 avatar Jun 24 '19 14:06 LuisPerez94

1 year old this issue. They grow so fast. If I get a moment I’ll try put in a pull request.

blwsh avatar Jun 24 '19 15:06 blwsh

Has a fix for this been released yet?

l3dger avatar Jul 26 '19 09:07 l3dger

This issue is also blocking solving https://github.com/akiran/react-slick/issues/1539

We can't set the height to be the same for all sides based on the tallest slide without rows: 0

samturner3 avatar Jul 30 '19 06:07 samturner3

Still crashes and took a lot of time to figure out in a big project...

partyconfetti avatar Mar 20 '20 23:03 partyconfetti

Dw! The world will end soon, we can mark this issue as “low priority”

blwsh avatar Mar 20 '20 23:03 blwsh

We almost defeated covid but we can't have a fixed slider in 2021.. I'll see if I can do it and open a PR.

TheHacker66 avatar Apr 16 '21 10:04 TheHacker66

Same here, sometimes crashes, sometimes open a debugger. Any updates?

vsdmoraes avatar May 27 '21 20:05 vsdmoraes

Same here crashes every time. The issue is also without rows: 0 the slider sets inline-block to slides which adds extra height to the slide. Even with line styles I can't overwrite this. See issue below from original slick repo:

https://github.com/kenwheeler/slick/issues/3581

JoeJHoward avatar Sep 14 '21 23:09 JoeJHoward

Has anyone found a solution here? This is affecting issue https://github.com/kenwheeler/slick/issues/3581 too.

adamcharvat avatar Jun 18 '23 04:06 adamcharvat

To address the styling conflicts, I found a workaround:

.slick-track .slick-slide > div {
    property: unset; /* or inherit; */
}

This should help resolve the issues related to conflicting styles.

prosperemebo avatar Jul 17 '24 22:07 prosperemebo