exq_ui icon indicating copy to clipboard operation
exq_ui copied to clipboard

Update deprecated syntax for live component

Open justinbkay opened this issue 3 years ago • 4 comments
trafficstars

justinbkay avatar Jul 22 '22 21:07 justinbkay

Thanks for the PR. But, we might not be able to merge right away, since this syntax is not supported by 0.16.x. You can check the previous PR related to this.

ananthakumaran avatar Jul 23 '22 03:07 ananthakumaran

Cool, any chance you’ll do a release with the table component id included? It seems to be in master, but not in the most recent version.

Thanks, Justin

On Fri, Jul 22, 2022 at 9:11 PM Anantha Kumaran @.***> wrote:

Thanks for the PR. But, we might not be able to merge right away, since this syntax is not supported by 0.16.x. You can check the previous PR https://github.com/akira/exq_ui/pull/109#issue-1099424288 related to this.

— Reply to this email directly, view it on GitHub https://github.com/akira/exq_ui/pull/122#issuecomment-1193047243, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA77RTSWOS36EN2KTNTETVVNPF7ANCNFSM54M2ODMA . You are receiving this because you authored the thread.Message ID: @.***>

-- Sites: https://www.boisemovies.com https://jbkayconstruction.com http://jbkayconstruction.com https://www.robsonoutfitters.com http://www.robsonoutfitters.com https://twitter.com/justinbkay

It always takes longer than you expect, even when you take into account Hofstadter’s Law.

  • Hofstadter’s Law

justinbkay avatar Jul 24 '22 00:07 justinbkay

It has been already released, check 0.12.2

ananthakumaran avatar Jul 24 '22 03:07 ananthakumaran

Thanks!

I was just a point release off.

On Sat, Jul 23, 2022 at 9:45 PM Anantha Kumaran @.***> wrote:

It has been already released, check 0.12.2 https://diff.hex.pm/diff/exq_ui/0.12.1..0.12.2

— Reply to this email directly, view it on GitHub https://github.com/akira/exq_ui/pull/122#issuecomment-1193240511, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAA77UEACNPMPVS3KWL4Y3VVS37HANCNFSM54M2ODMA . You are receiving this because you authored the thread.Message ID: @.***>

-- Sites: https://www.boisemovies.com https://jbkayconstruction.com http://jbkayconstruction.com https://www.robsonoutfitters.com http://www.robsonoutfitters.com https://twitter.com/justinbkay

It always takes longer than you expect, even when you take into account Hofstadter’s Law.

  • Hofstadter’s Law

justinbkay avatar Jul 24 '22 14:07 justinbkay

For others who might be looking at this PR due to seeing compilation errors as of yesterday, this happens in LiveView 0.18 (Released Sep 21, 2022).

We fixed this by temporarily downgrading to LiveView 0.17.x

atonse avatar Sep 22 '22 19:09 atonse

I will check soon, the last fix was done for 0.17.x

ananthakumaran avatar Sep 23 '22 13:09 ananthakumaran

@atonse pushed fix to master

ananthakumaran avatar Sep 24 '22 08:09 ananthakumaran