archetype icon indicating copy to clipboard operation
archetype copied to clipboard

Support for php-parser 5

Open jasonvarga opened this issue 1 year ago • 3 comments

This PR adds support for nikic/php-parser 5.0. It removes support for 4.0.

This has become necessary as PHPUnit 11 requires 5.0. PHPUnit 11 is now the default in Laravel.

jasonvarga avatar May 10 '24 19:05 jasonvarga

Hi Jason, thanks for this! Can you see what is failing here? image

ajthinking avatar May 10 '24 20:05 ajthinking

I'm not sure about that one. It fails during setup of the image. It's not a PHPUnit failure.

jasonvarga avatar May 10 '24 20:05 jasonvarga

It's because the composer command can't be found in that macos image.

CleanShot 2024-05-10 at 16 58 33

Then in the "cache dependencies" step, there is no path because it didnt get defined in the previous step.

As for why it's missing. I have no idea. It seems like it's not included with macos. Maybe it was at some point.

This failing step has nothing to do with this PR though. I would compare with previous workflow runs but there don't appear to be any. I have pushed an empty commit to the master branch on my fork to trigger the actions. You can see it failing there too.

jasonvarga avatar May 10 '24 20:05 jasonvarga

Found a way! Happy to see youre still using this package❤️ Releasing 2.0.0 shortly as this will be a breaking change.

ajthinking avatar May 11 '24 08:05 ajthinking

https://github.com/ajthinking/archetype/releases/tag/v2.0.0

Let me know if it needs any tweeking 👍

ajthinking avatar May 11 '24 08:05 ajthinking

Thank you!

jasonvarga avatar May 13 '24 14:05 jasonvarga