airbyte

airbyte copied to clipboard

What

https://github.com/airbytehq/airbyte/pull/38615 made the ConnectorContext try to fetch secrets for tests on initialization. But the ConnectorContext is the parent class of PublishContext. It led to failures in the publish workflow because PublishContext is not instantiated with the secret stores we use for testing.

Instead of passing the test secret store to PublishContext I find it more appropriate to create a ConnectorTestContext subclass in which the secret fetching for specific step is handled.

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		May 23, 2024 6:43pm

• #38628 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ SecretNotFoundError: No enabled secret version in GSM found for secret SECRET_SOURCE-COPPER__CREDS pipelines.models.secrets in _fetch_secret View Issue
• ‼️ TypeError: 'NoneType' object is not iterable pipelines.airbyte_ci.connectors.test.context in... View Issue

_{Did you find this useful? React with a 👍 or 👎}