react-with-styles icon indicating copy to clipboard operation
react-with-styles copied to clipboard

Published 20 hours ago • verified publisher icon airbnb

Issues with HMR

Open toddw opened this issue 8 years ago • 3 comments

When using react-with-styles and hot-module-replacement, the styles object passed in by props is not updating without a full page refresh.

toddw avatar Dec 02 '16 23:12 toddw

Thanks for the report! I'd be happy to review a PR that fixes this.

lencioni avatar Dec 02 '16 23:12 lencioni

@toddw, I recently upgraded a personal project to use React Hot Loader 3 (upgrade example) and react-with-styles does seem to be working with HMR. Maybe give that a shot?

mikefowler avatar Jan 06 '17 15:01 mikefowler

I'm facing the same issue as @toddw. Styling directly with aphrodite, hot module replacement (HMR) works as expected, and updates the style, but with react-with-styles, HMR seems to be broken and styles prop is not getting updated, thus not updating style as expected. Does react-with-styles do anything special to handle HMR? Or is something out of react-with-styles broken?

scho7623 avatar Sep 05 '18 00:09 scho7623