amVim-for-VSCode icon indicating copy to clipboard operation
amVim-for-VSCode copied to clipboard

Eliminate block cursor hack

Open ghost opened this issue 9 years ago • 8 comments

Version 0.10.8 has now has native support for a block cursor. (See microsoft/vscode PR #1586.)

ActionBlockCursor has a hack to simulate a block cursor. Unfortunately, toggling the block style is still not accessible through the extensions API. (See microsoft/vscode#561.) The implementation also has some minor aesthetic/readability issues. (See microsoft/vscode#2943.)

We can remove the hack now and recommend users toggle the editor.cursorStyle setting for themselves, or we can decide to wait for one or more of the outstanding issues to be resolved.

This issue can serve as a tracking bug.

ghost avatar Feb 11 '16 17:02 ghost

I tried the new native block cursor and it makes the character under cursor hard to see. I think we'd wait they solve the issue.

aioutecism avatar Feb 12 '16 04:02 aioutecism

Yes, you may want to subscribe to Microsoft/vscode#2943.

ghost avatar Feb 12 '16 06:02 ghost

may be able to refer to this sample from vscode. https://github.com/alexandrudima/vscode-vim

holmeszyx avatar Apr 01 '16 02:04 holmeszyx

@holmeszyx The problem is the native block cursor makes the character under cursor hard to see. The official sample shows how to change cursor style by extension, but not solving the visual problem.

aioutecism avatar Apr 01 '16 07:04 aioutecism

vimStyle has the behavior the OP wants. But as @aioutecism, the character under cursor is hidden since the block cursor is opaque.

andradei avatar Apr 15 '16 15:04 andradei

latest code release should fix the opaque block cursor, so please make it native. It's hard to tell which you mode in when cursor located at matched bracket pair

asvetliakov avatar May 15 '16 23:05 asvetliakov

I think PR #103 is related to this issue.

shamrin avatar Jun 10 '16 09:06 shamrin

I'm leaving this open until block cursor in visual mode is supported.

aioutecism avatar Jun 10 '16 09:06 aioutecism