aiohttp

aiohttp copied to clipboard

What do these changes do?

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

Related issue number

Checklist

• [ ] I think the code is well written
• [ ] Unit tests for the changes exist
• [ ] Documentation reflects the changes
• [ ] If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• [ ] Add a new news fragment into the CHANGES/ folder

  • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

  • if you don't have an issue number, change it to the pull request number after creating the PR

    • .bugfix: A bug fix for something the maintainers deemed an improper undesired behavior that got corrected to match pre-agreed expectations.
    • .feature: A new behavior, public APIs. That sort of stuff.
    • .deprecation: A declaration of future API removals and breaking changes in behavior.
    • .breaking: When something public is removed in a breaking way. Could be deprecated in an earlier release.
    • .doc: Notable updates to the documentation structure or build process.
    • .packaging: Notes for downstreams about unobvious side effects and tooling. Changes in the test invocation considerations and runtime assumptions.
    • .contrib: Stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment.
    • .misc: Changes that are hard to assign to any of the above categories.

  • Make sure to use full sentences with correct case and punctuation, for example:

    Fixed issue with non-ascii contents in doctest text files
    -- by :user:`contributor-gh-handle`.
    

    Use the past tense or the present tense a non-imperative mood, referring to what's changed compared to the last released version of this project.

Jun 01 '24 00:06 edgarrmondragon

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.64%. Comparing base (8504b71) to head (9909716). Report is 1 commits behind head on master.

@@           Coverage Diff           @@
##           master    #8432   +/-   ##
=======================================
  Coverage   97.64%   97.64%           
=======================================
  Files         107      107           
  Lines       33067    33067           
  Branches     3885     3885           
=======================================
  Hits        32288    32288           
  Misses        562      562           
  Partials      217      217           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jun 01 '24 00:06 codecov[bot]

It seems pycares is also causing issues

Jun 01 '24 01:06 edgarrmondragon

Looks like uvloop is also failing to install currently. I suspect there's a good chance cffi will have made a stable release by the time that's sorted, so maybe not worth putting these changes in temporarily.

Jun 01 '24 12:06 Dreamsorcerer

Looks like cffi 1.17.0 is now out

Aug 07 '24 12:08 bdraco

I guess we close this then, as Dependabot will update it. Just waiting on uvloop now..

Aug 07 '24 12:08 Dreamsorcerer