aioelasticsearch icon indicating copy to clipboard operation
aioelasticsearch copied to clipboard

implement scan for composite aggregation

Open pgtuk opened this issue 5 years ago • 2 comments

What do these changes do?

Added convenient scan for composite aggregations as specified in es docs.

Are there changes in behavior for the user?

None.

Checklist

  • [x] I think the code is well written
  • [x] Unit tests for the changes exist
  • [ ] Documentation reflects the changes
  • [ ] Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

pgtuk avatar Jul 15 '20 09:07 pgtuk

Codecov Report

Merging #225 into master will decrease coverage by 0.03%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #225      +/-   ##
=========================================
- Coverage    0.23%   0.19%   -0.04%     
=========================================
  Files           6       6              
  Lines         434     520      +86     
  Branches       76      89      +13     
=========================================
  Hits            1       1              
- Misses        433     519      +86     
Impacted Files Coverage Δ
aioelasticsearch/helpers.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c8498b5...05c358b. Read the comment docs.

codecov[bot] avatar Jul 15 '20 09:07 codecov[bot]

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Petro Kostiukevych seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 16 '20 10:11 CLAassistant