aioelasticsearch

aioelasticsearch copied to clipboard

What do these changes do?

Changing setup.py to support both ES 6 and ES 7 via extras_require in setup.py. Omitting it will render library broken.
Tests are rewritten to support both versions.

Are there changes in behavior for the user?

Support for ES7, the installation now requires an explicit version in square brackets:

pip install aioelasticsearch[6]

or

pip install aioelasticsearch[7]

Related issue number

https://github.com/aio-libs/aioelasticsearch/issues/158

Checklist

• [ x ] I think the code is well written
• [ x ] Unit tests for the changes exist
• [ x ] Documentation reflects the changes
• [ ] If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• [ ] Add a new news fragment into the CHANGES folder
  • name it <issue_id>.<type> (e.g. 588.bugfix)
  • if you don't have an issue_id change it to the pr id after creating the PR
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

This pull request introduces 1 alert when merging 9aadaf4fcce1db00d0fa28280cb7cd7a8f961fff into 3e766c7ce8eb6f5bc8e1505d24e3413472f37485 - view on LGTM.com

new alerts:

• 1 for __eq__ not overridden when adding attributes

This pull request introduces 1 alert when merging 50eed213c0272b6c4eb1691dababc7f6d8f187d6 into 3e766c7ce8eb6f5bc8e1505d24e3413472f37485 - view on LGTM.com

new alerts:

• 1 for __eq__ not overridden when adding attributes

This pull request introduces 1 alert when merging 951230ca326990827dd51f17f5efe2fb4bd580d7 into 3e766c7ce8eb6f5bc8e1505d24e3413472f37485 - view on LGTM.com

new alerts:

• 1 for __eq__ not overridden when adding attributes

This pull request introduces 1 alert when merging 683564b9fff885b8930e81cf0d06c54500f5506f into 3e766c7ce8eb6f5bc8e1505d24e3413472f37485 - view on LGTM.com

new alerts:

• 1 for __eq__ not overridden when adding attributes

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}