million icon indicating copy to clipboard operation
million copied to clipboard

bug: Compilation error on react 16

Open manoharc1999 opened this issue 2 years ago • 7 comments

Describe the bug Compilation error while running on react 16

"react": "^16.13.0", "react-dom": "^16.13.0", "million": "2.4.4", node: 14.21.3 npm: 6.14.18 webpack: 5

To Reproduce Steps to reproduce the behavior:

  1. Use React v16
  2. Use For on any list
  3. Compilation error

Expected behavior project should compile

Screenshots image

Device (please complete the following information):

  • OS linux
  • Browse chrome

Additional context Add any other context about the problem here.

manoharc1999 avatar Jun 11 '23 06:06 manoharc1999

@aidenybai what is the minimum react version required?

manoharc1999 avatar Jun 11 '23 06:06 manoharc1999

Describe the bug Compilation error while running on react 16

"react": "^16.13.0", "react-dom": "^16.13.0", "million": "2.4.4", node: 14.21.3 npm: 6.14.18 webpack: 5

To Reproduce Steps to reproduce the behavior:

  1. Use React v16
  2. Use For on any list
  3. Compilation error

Expected behavior project should compile

Screenshots image

Device (please complete the following information):

  • OS linux
  • Browse chrome

Additional context Add any other context about the problem here.

I don't really see what the error is here, I'll definitely need more information so I can help out. Did you properly set up the compiler? Also, can I see your code?

tobySolutions avatar Jun 11 '23 06:06 tobySolutions

should be fixed in latest version

aidenybai avatar Jun 12 '23 07:06 aidenybai

still getting compilation error. Interestingly my project compiled successfully with 2.1.0 version. Didnt try any other versions

manoharc1999 avatar Jun 12 '23 14:06 manoharc1999

Oh! Interesting. 🤔🤔. So, it works now @manoharc1999?

tobySolutions avatar Jun 13 '23 07:06 tobySolutions

Try upgrading to the latest beta, should work now possibly. Thanks for the patience so far @manoharc1999

aidenybai avatar Jun 13 '23 08:06 aidenybai

Tested it just now with node 16.19.1 , the issue still exists on 2.4.6-beta.0

aimen08 avatar Jun 13 '23 10:06 aimen08

This is very interesting, does this work on React 18? Or is it just React 16?

aidenybai avatar Jun 13 '23 20:06 aidenybai

@tobySolutions , @aidenybai Can it be bcz of this change https://github.com/aidenybai/million/pull/311/files?

manoharc1999 avatar Jun 16 '23 14:06 manoharc1999

Try upgrading to the latest beta, should work now possibly. Thanks for the patience so far @manoharc1999

Still not working in latest beta :(

manoharc1999 avatar Jun 16 '23 15:06 manoharc1999

Try upgrading to the latest beta, should work now possibly. Thanks for the patience so far @manoharc1999

Still not working in latest beta :(

Oh, seriously?? 👀👀 You getting any errors?

tobySolutions avatar Jun 16 '23 15:06 tobySolutions

Update on this: We are not actively supporting any React version under React 18 until future notice.

aidenybai avatar Jun 16 '23 21:06 aidenybai

Cannot resolve react-dom/client

Describe the bug Compilation error while running on react 16 "react": "^16.13.0", "react-dom": "^16.13.0", "million": "2.4.4", node: 14.21.3 npm: 6.14.18 webpack: 5 To Reproduce Steps to reproduce the behavior:

  1. Use React v16
  2. Use For on any list
  3. Compilation error

Expected behavior project should compile Screenshots image Device (please complete the following information):

  • OS linux
  • Browse chrome

Additional context Add any other context about the problem here.

I don't really see what the error is here, I'll definitely need more information so I can help out. Did you properly set up the compiler? Also, can I see your code?

Describe the bug Compilation error while running on react 16

"react": "^16.13.0", "react-dom": "^16.13.0", "million": "2.4.4", node: 14.21.3 npm: 6.14.18 webpack: 5

To Reproduce Steps to reproduce the behavior:

  1. Use React v16
  2. Use For on any list
  3. Compilation error

Expected behavior project should compile

Screenshots image

Device (please complete the following information):

  • OS linux
  • Browse chrome

Additional context Add any other context about the problem here.

manoharc1999 avatar Jun 17 '23 01:06 manoharc1999