million icon indicating copy to clipboard operation
million copied to clipboard

bug: Documentation search bar doesn't work

Open ryanjmack opened this issue 3 years ago • 1 comments

Describe the bug Trying to search something in the million documentation causes an endless spinner

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://millionjs.org/'
  2. Click on the search bar
  3. Type in the search bar, notice the endless spinner
  4. console has this error: "Uncaught (in promise) SyntaxError: Unexpected token < in JSON at position 0"
  5. Hit enter key, still has endless spinner
  6. an additional console error bubbles up: "Uncaught TypeError: Cannot read properties of undefined (reading 'route')"

Expected behavior I'd expect the search function to work

Screenshots Screen Shot 2022-08-02 at 4 39 02 PM

Device (please complete the following information):

  • OS: iOS (Big Sur v11.6)
  • Browser: Chrome v103
  • Version: latest million release

ryanjmack avatar Aug 02 '22 23:08 ryanjmack

Hey, @ryanjmack I would like to work on this issue if no one else is working on it. Thanks!

noobyogi0010 avatar Aug 03 '22 05:08 noobyogi0010

Hey @noobyogi0010, any update on this? Do you need any help with this issue so far?

aidenybai avatar Aug 10 '22 04:08 aidenybai

Hey @aidenybai I am still working on this issue. Sorry, I didn't get much time to focus on it completely. Will try to wrap it up by end of this week. Thanks!

noobyogi0010 avatar Aug 10 '22 17:08 noobyogi0010

No worries, take your time. If you need any help, feel free to comment any questions here or in the Discord :)

aidenybai avatar Aug 11 '22 05:08 aidenybai

@aidenybai I am not able to reproduce this issue. Neither on my local system nor on the million's documentation.

noobyogi0010 avatar Aug 11 '22 07:08 noobyogi0010

@noobyogi0010, same here, I'm not getting that issue on Brave or Chrome.

BraydenTW avatar Aug 11 '22 14:08 BraydenTW

@ryanjmack, could you test this issue again? Possibly a recent commit to docs fixed this issue

aidenybai avatar Aug 11 '22 19:08 aidenybai

@aidenybai the issue seems to be resolved, so I'm closing it!

ryanjmack avatar Aug 11 '22 21:08 ryanjmack