Benjamin Wang
Benjamin Wang
> Can you please tell me where I went wrong in reproducing the error? I followed the same given commands for terminal x and y. Two comments: 1. The environment...
Just as I mentioned previously https://github.com/etcd-io/etcd/issues/13757#issuecomment-1057718054, each member can have multiple peer URLs. In the following example, `http://1.1.1.1:2380` and `http://2.2.2.2::2380` are regarded as two peer URLs of the member `mach0`....
cc @serathius @ptabor @spzala @mitake
Please note that I intentionally broke down the PR into three commits, and I recommend to review this PR commit by commit. [lease: add a lease_new request into raft_internal.proto](https://github.com/etcd-io/etcd/pull/14094/commits/23d98746a1ce25da9804061d6d7acf0ab8190663) [lease:...
This is a standalone refactor on `Renew` instead of `Grant`. It took me sometime to go through some historical PRs ( [9924](https://github.com/etcd-io/etcd/pull/9924), [9526](https://github.com/etcd-io/etcd/pull/9526), [9699](https://github.com/etcd-io/etcd/pull/9699), [13508](https://github.com/etcd-io/etcd/pull/13508) ) before delivering this PR....
Thanks both @cenkalti and @ramses for the feedback. Actually I tried the `golangci-lint` as well about 9 months ago in project [gocontainer](https://github.com/ahrtr/gocontainer), and I believe it's definitely useful, but we...
> The chosen configuration of `golangci-lint` does not include `revive` thus there is still the risk of not detecting bugs as those mentioned in the initial message of this discussion....
This task isn't finished yet. https://github.com/etcd-io/etcd/pull/14255 is just the very first step. Please anyone feel free to continue to work on this task.
> I added the GitHub action: #14392 I added `revive` to the list of linters: #14391 > > Can you review these please? Thank you @cenkalti . Approved and merged.
Please consider to resolve https://github.com/etcd-io/etcd/pull/14479#issuecomment-1249195534