aehmc icon indicating copy to clipboard operation
aehmc copied to clipboard

Published 20 hours ago • verified publisher icon aesara-devs

Update step size dtypes

Open brandonwillard opened this issue 2 years ago • 1 comments

In #86, I updated the step size dtypes to int64, but I imagine it would be better to perform that conversion somewhere within AeHMC; however, I don't know the best place for that at the moment.

@rlouf, if you get a minute, tell me where you think an astype could be performed so that users can specify int32 and avoid those Scan casting issues.

Originally posted by @brandonwillard in https://github.com/aesara-devs/aehmc/issues/86#issuecomment-1370220761

brandonwillard avatar Jan 03 '23 21:01 brandonwillard

As far as I understand, you cast the number of steps to int64. The high-level entry points of the library, and that you might want to use in a Scan are here:

  • https://github.com/aesara-devs/aehmc/blob/d54e2d05512d8d3d4aea92b8732854e6794296e8/aehmc/window_adaptation.py#L85
  • https://github.com/aesara-devs/aehmc/blob/d54e2d05512d8d3d4aea92b8732854e6794296e8/aehmc/hmc.py#L73

It seems that you've covered the internal ones already.

rlouf avatar Mar 10 '23 08:03 rlouf