wasm4 icon indicating copy to clipboard operation
wasm4 copied to clipboard

Published 20 hours ago • verified publisher icon aduros

Allow recording of videos at any duration

Open TLAlice opened this issue 3 years ago • 3 comments

Changed the recordVideo function so that instead of pressing record and then recording for 4 seconds, gameplay starts being recorded upon pressing record until pressing it again

TLAlice avatar Jan 11 '22 13:01 TLAlice

✔️ Deploy Preview for wasm4 ready!

🔨 Explore the source changes: 7085765b85ed18deafb26b40bb31f7c7c4ca2cf2

🔍 Inspect the deploy log: https://app.netlify.com/sites/wasm4/deploys/61dd85e7c3c79500076f0373

😎 Browse the preview: https://deploy-preview-301--wasm4.netlify.app

netlify[bot] avatar Jan 11 '22 13:01 netlify[bot]

Hi Alice, thanks for the PR!

I think we need to keep some sort of maximum timeout for the video recording. Otherwise it's likely that the user will forget to press the record key a second time, which will probably run the browser out of memory and crash the tab :grin:

Can you change it to keep the setTimeout, but increase it to 30-60 seconds, but still allow you to press record again to stop early?

aduros avatar Jan 12 '22 14:01 aduros

Do we not show any indication that the video is being recored to remind them?

joshgoebel avatar Jan 12 '22 17:01 joshgoebel