ember-light-table icon indicating copy to clipboard operation
ember-light-table copied to clipboard

Published 20 hours ago • verified publisher icon adopted-ember-addons

Remove ember-responsive install from blueprint

Open maxwondercorn opened this issue 3 years ago • 3 comments

maxwondercorn avatar Jul 31 '22 22:07 maxwondercorn

@maxwondercorn are we sure we don't need this? I think the idea behind installing it is it will create the breakpoints.js file in the consuming app and set all that up.

RobbieTheWagner avatar Aug 04 '22 14:08 RobbieTheWagner

@rwwagner90 I did forget about the breakpoints file. I was only looking at ember-responsive moving from devDependencies to addon dependencies. Does it really make sense to have it in both?

maxwondercorn avatar Aug 04 '22 16:08 maxwondercorn

@maxwondercorn I think it should be in dependencies, since we're requiring it. Perhaps we could use afterInstall to run ember g ember-responsive or something like that?

RobbieTheWagner avatar Aug 05 '22 16:08 RobbieTheWagner