spectrum-web-components

spectrum-web-components copied to clipboard

Description

Include link to Storybook on the component pages.

Related issue(s)

• #4008

Motivation and context

The link to our storybook is sort of "hidden" in our documentation. You have to scroll down the components list and then you find the storybook. Linking it on top would encourage consumers to look for examples in storybook also.

How has this been tested?

• [ ] Test case 1
  1. Go here
  2. Do this
• [ ] Test case 2
  1. Go here
  2. Do this

Screenshots (if appropriate)

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [x] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

• [x] I have signed the Adobe Open Source CLA.
• [x] My code follows the code style of this project.
• [x] If my change required a change to the documentation, I have updated the documentation in this pull request.
• [x] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes.
• [x] All new and existing tests passed.
• [x] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

Branch preview

• Documentation Site
• Storybook

Lighthouse scores

Category	Latest (report)	Main (report)	Branch (report)
Performance	0.93	0.97	0.97
Accessibility	1	1	1
Best Practices	1	1	1
SEO	1	0.92	0.92
PWA	1	1	1

What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category	Latest	Main	Branch
Total	242.433 kB	226.942 kB	226.703 kB 🏆
Scripts	59.565 kB	53.703 kB	53.507 kB 🏆
Stylesheet	50.418 kB	41.369 kB	41.342 kB 🏆
Document	5.738 kB	5.128 kB 🏆	5.14 kB
Third Party	126.712 kB 🏆	126.742 kB	126.714 kB

Request Count

Category	Latest	Main	Branch
Total	42 🏆	43	43
Scripts	34 🏆	35	35
Stylesheet	5	5	5
Document	1	1	1
Third Party	2	2	2

Tachometer results

Currently, no packages are changed by this PR...

FYI.

Can we use https://caniuse.com/css-container-queries to make sure that this: Until you can fit all cards in a single row?

Updated!