spectrum-web-components
spectrum-web-components copied to clipboard
Published
20 hours ago •
adobe
adobe
fix: don't close the top overlay on click if it's triggered by hover
Description
This PR addresses the issue outlined in CCEX-8559 where clicking on an overlay trigger that has a hover element results in overlays shown by click not closing.
Related issue(s)
Fixes #2539
Motivation and context
This issue was found while addressing CCEX-8559.
How has this been tested?
- [ ] Test case 1
- Go to Storybook, select Overlay, select Click And Hover Targets
- Follow the instructions
Screenshots (if appropriate)
Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)
Checklist
- [x] I have signed the Adobe Open Source CLA.
- [x] My code follows the code style of this project.
- [x] If my change required a change to the documentation, I have updated the documentation in this pull request.
- [x] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
- [ ] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.
Branch Preview
Visual regression test results
When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
- High Contrast Mode | Medium | LTR
- Classic | Lightest | Medium | LTR
- Classic | Lightest | Medium | RTL
- Classic | Lightest | Large | LTR
- Classic | Lightest | Large | RTL
- Classic | Light | Medium | LTR
- Classic | Light | Medium | RTL
- Classic | Light | Large | LTR
- Classic | Light | Large | RTL
- Classic | Dark | Medium | LTR
- Classic | Dark | Medium | RTL
- Classic | Dark | Large | LTR
- Classic | Dark | Large | RTL
- Classic | Darkest | Medium | LTR
- Classic | Darkest | Medium | RTL
- Classic | Darkest | Large | LTR
- Classic | Darkest | Large | RTL
- Express | Lightest | Medium | LTR
- Express | Lightest | Medium | RTL
- Express | Lightest | Large | LTR
- Express | Lightest | Large | RTL
- Express | Light | Medium | LTR
- Express | Light | Medium | RTL
- Express | Light | Large | LTR
- Express | Light | Large | RTL
- Express | Dark | Medium | LTR
- Express | Dark | Medium | RTL
- Express | Dark | Large | LTR
- Express | Dark | Large | RTL
- Express | Darkest | Medium | LTR
- Express | Darkest | Medium | RTL
- Express | Darkest | Large | LTR
- Express | Darkest | Large | RTL
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Tachometer results
Chrome
action-bar permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 232 kB | 39.87ms - 40.78ms | - | unsure 🔍 -1% - +2% -0.24ms - +0.86ms |
| branch | 232 kB | 39.70ms - 40.32ms | unsure 🔍 -2% - +1% -0.86ms - +0.24ms |
- |
action-menu permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 593 kB | 267.23ms - 271.43ms | - | unsure 🔍 -1% - +1% -1.55ms - +3.73ms |
| branch | 594 kB | 266.64ms - 269.83ms | unsure 🔍 -1% - +1% -3.73ms - +1.55ms |
- |
menu permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 296 kB | 296.63ms - 303.65ms | - | unsure 🔍 -1% - +2% -3.44ms - +4.85ms |
| branch | 297 kB | 297.23ms - 301.63ms | unsure 🔍 -2% - +1% -4.85ms - +3.44ms |
- |
overlay permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 334 kB | 97.88ms - 100.42ms | - | unsure 🔍 -0% - +3% -0.19ms - +2.67ms |
| branch | 335 kB | 97.25ms - 98.57ms | unsure 🔍 -3% - +0% -2.67ms - +0.19ms |
- |
picker permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 440 kB | 934.20ms - 959.41ms | - | unsure 🔍 -2% - +2% -18.72ms - +14.33ms |
| branch | 441 kB | 938.31ms - 959.68ms | unsure 🔍 -2% - +2% -14.33ms - +18.72ms |
- |
popover permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 229 kB | 41.68ms - 42.61ms | - | unsure 🔍 -3% - +1% -1.36ms - +0.28ms |
| branch | 229 kB | 42.02ms - 43.36ms | unsure 🔍 -1% - +3% -0.28ms - +1.36ms |
- |
split-button permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 532 kB | 1967.84ms - 1971.51ms | - | unsure 🔍 -0% - +0% -0.79ms - +4.19ms |
| branch | 533 kB | 1966.29ms - 1969.65ms | unsure 🔍 -0% - +0% -4.19ms - +0.79ms |
- |
tooltip permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 235 kB | 44.57ms - 45.64ms | - | unsure 🔍 -3% - +1% -1.32ms - +0.39ms |
| branch | 235 kB | 44.91ms - 46.24ms | unsure 🔍 -1% - +3% -0.39ms - +1.32ms |
- |
Firefox
action-bar permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 232 kB | 90.87ms - 94.33ms | - | unsure 🔍 -7% - +1% -6.86ms - +1.26ms |
| branch | 232 kB | 91.73ms - 99.07ms | unsure 🔍 -1% - +7% -1.26ms - +6.86ms |
- |
action-menu permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 593 kB | 396.05ms - 408.07ms | - | unsure 🔍 -3% - +1% -10.67ms - +4.43ms |
| branch | 594 kB | 400.62ms - 409.74ms | unsure 🔍 -1% - +3% -4.43ms - +10.67ms |
- |
menu permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 296 kB | 522.10ms - 532.94ms | - | unsure 🔍 -2% - +1% -10.52ms - +4.00ms |
| branch | 297 kB | 525.94ms - 535.62ms | unsure 🔍 -1% - +2% -4.00ms - +10.52ms |
- |
overlay permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 334 kB | 156.28ms - 162.88ms | - | unsure 🔍 -3% - +2% -5.43ms - +3.03ms |
| branch | 335 kB | 158.14ms - 163.42ms | unsure 🔍 -2% - +3% -3.03ms - +5.43ms |
- |
picker permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 440 kB | 1064.24ms - 1072.40ms | - | faster ✔ 0% - 1% 2.44ms - 13.76ms |
| branch | 441 kB | 1072.51ms - 1080.33ms | slower ❌ 0% - 1% 2.44ms - 13.76ms |
- |
popover permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 229 kB | 73.43ms - 84.69ms | - | faster ✔ 4% - 23% 2.52ms - 21.88ms |
| branch | 229 kB | 83.39ms - 99.13ms | slower ❌ 3% - 28% 2.52ms - 21.88ms |
- |
split-button permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 532 kB | 2067.53ms - 2079.07ms | - | unsure 🔍 -0% - +0% -6.64ms - +8.24ms |
| branch | 533 kB | 2067.81ms - 2077.19ms | unsure 🔍 -0% - +0% -8.24ms - +6.64ms |
- |
tooltip permalink
| Version | Bytes | Avg Time | vs remote | vs branch |
|---|---|---|---|---|
| npm latest | 235 kB | 69.26ms - 75.22ms | - | faster ✔ 3% - 15% 2.00ms - 12.48ms |
| branch | 235 kB | 75.17ms - 83.79ms | slower ❌ 3% - 18% 2.00ms - 12.48ms |
- |