spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

[Feat]: Expose {confirm,secondary,cancel}Disabled in DialogWrapper

Open OpportunityLiu opened this issue 4 years ago • 1 comments

Code of conduct

  • [X] I agree to follow this project's code of conduct.

Impacted component(s)

DialogWrapper

Description of the requested feature

expose confirmDisabled, secondaryDisabled, cancelDisabled property that binds to sp-buttons' disabled property

Mockups or screenshots

No response

Implementation notes or ideas

No response

OpportunityLiu avatar Oct 14 '21 04:10 OpportunityLiu

Or at least extract methods like renderSecondaryButton, so that I can override them in my sub classes. Today's one render method is hard to override, and will easily broken in version updates.

For overriding, dismiss, clickSecondary, clickCancel, clickConfirm should be exposed as protected method

OpportunityLiu avatar Oct 14 '21 04:10 OpportunityLiu