spectrum-web-components icon indicating copy to clipboard operation
spectrum-web-components copied to clipboard

[Feat]: `sp-action-menu` should support customizing the internal `sp-menu`

Open charlessuh opened this issue 4 years ago • 1 comments

Code of conduct

  • [X] I agree to follow this project's code of conduct.

Impacted component(s)

sp-action-menu

Description of the requested feature

When using sp-action-menu, there is no way to customize the internal sp-menu that is opened. Potential use cases could be specifying a max-width, or overriding a supported CSS variable.

For example, perhaps sp-action-menu could support a menu slot:

<sp-action-menu size="m">
    <span slot="label">More Actions</span>
    <sp-menu slot="menu" style="max-width: 400px; --spectrum-listitem-m-height: 50px;">
        <sp-menu-item />
    </sp-menu>
</sp-action-menu>

Mockups or screenshots

No response

Implementation notes or ideas

No response

charlessuh avatar Oct 04 '21 18:10 charlessuh

We should review the previous decision to remove sp-menu with @adixon-adobe

hunterloftis avatar Oct 13 '21 17:10 hunterloftis

Will be addressed by #2086

najikahalsema avatar Oct 26 '22 18:10 najikahalsema