spectrum-css icon indicating copy to clipboard operation
spectrum-css copied to clipboard

feat(swatch)!: migrate swatch to core tokens

Open yosevu opened this issue 3 years ago • 2 comments

Description

  • Update windows high contrast mode
  • Update YAML examples
    • Rename --spectrum-picked-color to --mod-swatch-fill-background-color
    • Add is-image class to Image, Gradient, and Mixed Value swatches for transparent backgrounds

Note: There are currently two open questions about border colors and the XS workflow icon size in Slack, however, these may not be blockers for this work.

How and where has this been tested?

  • Tested locally referencing the Swatch XD file.
  • Tested WHCM with forced colors in Chrome Emulation
  • Medium and Large scales

Screenshots

To-do list

  • [x] If my change impacts other components, I have tested to make sure they don't break.
  • [x] If my change impacts documentation, I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have tested these changes in Windows High Contrast mode.
  • [ ] This pull request is ready to merge.

yosevu avatar Aug 18 '22 12:08 yosevu

🚀 Deployed on https://pr-1501--spectrum-css.netlify.app

github-actions[bot] avatar Aug 18 '22 12:08 github-actions[bot]

VRT is: https://spectrum-visual-regression.ci.corp.adobe.com/view/Spectrum%20CSS/job/css-vrt-test/39 1501 - swatch.zip

bernhard-adobe avatar Aug 23 '22 21:08 bernhard-adobe

Released beta: @spectrum-css/[email protected]

@yosevu can you open a PR in the Spectrum Web Components repo with this update? Note the version number here ☝🏻 - I had a bad publish at the 2.0.0-beta.0 release, so use the .1 one, please.

pfulton avatar Aug 30 '22 15:08 pfulton

Also, I've rebased this branch against the latest stuff in main.

pfulton avatar Aug 30 '22 15:08 pfulton

@pfulton or @GarthDB could you create a new beta release for Swatch please?

yosevu avatar Sep 12 '22 15:09 yosevu

Released: - @spectrum-css/[email protected]

pfulton avatar Sep 12 '22 15:09 pfulton

Released: @spectrum-css/[email protected]

pfulton avatar Sep 28 '22 16:09 pfulton