spectrum-css icon indicating copy to clipboard operation
spectrum-css copied to clipboard

feat(statuslight)!: migrate statuslight to core tokens

Open yosevu opened this issue 3 years ago • 3 comments

Description

  • Move skin.css styles to index.css
  • Update windows high contrast mode styles
  • Update semantic and non-semantic color examples to align with batch 2 XD file
  • Remove deprecated colors
  • Remove disabled state based on note in batch 2 XD file

How and where has this been tested?

  • Tested locally referencing the Progress-bar XD file.
  • Tested WHCM with forced colors in Chrome Emulation

Screenshots

Screen Shot 2022-08-10 at 8 01 29 AM Screen Shot 2022-08-10 at 8 00 57 AM Screen Shot 2022-08-10 at 8 00 47 AM Screen Shot 2022-08-10 at 8 00 34 AM

To-do list

  • [x] If my change impacts other components, I have tested to make sure they don't break.
  • [x] If my change impacts documentation, I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have tested these changes in Windows High Contrast mode.
  • [ ] This pull request is ready to merge.

yosevu avatar Aug 09 '22 22:08 yosevu

🚀 Deployed on https://pr-1495--spectrum-css.netlify.app

github-actions[bot] avatar Aug 09 '22 23:08 github-actions[bot]

VRT test is: https://spectrum-visual-regression.ci.corp.adobe.com/view/Spectrum%20CSS/job/css-vrt-test/29/

bernhard-adobe avatar Aug 10 '22 22:08 bernhard-adobe

Released: @spectrum-css/[email protected]

pfulton avatar Aug 16 '22 20:08 pfulton

@yosevu - there was a core tokens release that will affect the colors for StatusLight. The CSS tokens package for those changes will be in: - @spectrum-css/[email protected].

There's also a Jira ticket about this: https://jira.corp.adobe.com/browse/CSS-240

pfulton avatar Aug 26 '22 14:08 pfulton

@yosevu - there was a core tokens release that will affect the colors for StatusLight. The CSS tokens package for those changes will be in: - @spectrum-css/[email protected].

There's also a Jira ticket about this: https://jira.corp.adobe.com/browse/CSS-240

I updated tokens to 1.0.7 @pfulton

yosevu avatar Aug 29 '22 10:08 yosevu

Thanks!

pfulton avatar Aug 29 '22 14:08 pfulton

Released: 5.0.0-beta.1

pfulton avatar Aug 29 '22 14:08 pfulton

FYI, I bumped the version number to the latest beta release in the Web Components PR.

pfulton avatar Aug 29 '22 14:08 pfulton