spectrum-css

spectrum-css copied to clipboard

Description

This PR migrates the Toast component to core-tokens.

• Removes deprecated variants (warning, error, success)

How and where has this been tested?

• Tested locally referencing the Components batch 2 XD file.
• Tested with VoiceOver on Safari
• Tested WHCM with forced colors in Chrome Emulation

Screenshots

To-do list

~~- [ ] If my change impacts other components, I have tested to make sure they don't break.~~ ~~- [ ] If my change impacts documentation, I have updated the documentation accordingly.~~

• [x] I have read the CONTRIBUTING document.
• [x] I have tested these changes in Windows High Contrast mode.

• [x] This pull request is ready to merge.

🚀 Deployed on https://pr-1483--spectrum-css.netlify.app

Beta released: - @spectrum-css/[email protected]

New beta released due to faulty build: - @spectrum-css/[email protected]

@yosevu We're seeing some size changes and close button issues when we try to integrate this with the Spectrum Web Components project.

Here's my draft PR where you can take a look at their VRT results.

Would you mind double-checking on the sizing and maybe also try bringing in the latest release of the CloseButton? That might actually help things.

I updated the token used for the padding-inline of the close button. I believe this was the issue based on the comment in @pfulton draft PR. Would you mind taking a look confirm it @bernhard-adobe? I also updated to the latest CloseButton package.

Design: Beta: Updated:

VRT is: https://spectrum-visual-regression.ci.corp.adobe.com/view/Spectrum%20CSS/job/css-vrt-test/31/

VRT test is https://spectrum-visual-regression.ci.corp.adobe.com/view/Spectrum%20CSS/job/css-vrt-test/31/artifact/backstop_data/html_report/index.html 2022-08-10 -- 1483 - toast.zip

Released: 8.0.0-beta.2

Could I get a new release for this @pfulton or @GarthDB?

Released: @spectrum-css/[email protected]

I think we're ready to merge this in and graduate the release.