aem-core-forms-components

aem-core-forms-components copied to clipboard

Description

FORMS-11276 : Text component does not appear in the viewport when the 'setFocus' is triggered on the Text Component

Related Issue

setFocus was not only working for text but also for radioButton and checkbox

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [ ] I have signed the Adobe Open Source CLA.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes and the overall coverage did not decrease.
• [ ] All unit tests pass on CircleCi.
• [ ] I ran all tests locally and they pass.

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	85	100	100	73

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

Codecov Report

Merging #934 (5dca4a2) into dev (3c45dde) will increase coverage by 0.00%. Report is 10 commits behind head on dev. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                dev     #934   +/-   ##
=========================================
  Coverage     80.56%   80.56%           
+ Complexity      735      732    -3     
=========================================
  Files            91       90    -1     
  Lines          2048     2043    -5     
  Branches        271      269    -2     
=========================================
- Hits           1650     1646    -4     
  Misses          248      248           
+ Partials        150      149    -1     

Files	Coverage Δ
...s/core/components/internal/form/FormConstants.java	100.00% <ø> (ø)
...nts/internal/models/v2/form/FormContainerImpl.java	70.93% <100.00%> (+0.34%)	:arrow_up:
...rms/core/components/models/form/FormContainer.java	25.92% <100.00%> (+2.84%)	:arrow_up:
...rms/core/components/util/AbstractCheckboxImpl.java	100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	88	100	100	73

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate