aem-core-forms-components

aem-core-forms-components copied to clipboard

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [ ] I have signed the Adobe Open Source CLA.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes and the overall coverage did not decrease.
• [ ] All unit tests pass on CircleCi.
• [ ] I ran all tests locally and they pass.

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	100	100	73

Codecov Report

Merging #869 (8142162) into dev (ff965f1) will decrease coverage by 0.16%. Report is 6 commits behind head on dev. The diff coverage is 0.00%.

:exclamation: Current head 8142162 differs from pull request most recent head 791db0d. Consider uploading reports for the commit 791db0d to get more accurate results

@@             Coverage Diff              @@
##                dev     #869      +/-   ##
============================================
- Coverage     80.54%   80.39%   -0.16%     
  Complexity      730      730              
============================================
  Files            90       91       +1     
  Lines          2041     2045       +4     
  Branches        269      269              
============================================
  Hits           1644     1644              
- Misses          248      252       +4     
  Partials        149      149              

Files	Coverage Δ
.../components/internal/models/v1/form/PanelImpl.java	93.33% <0.00%> (-3.22%)	:arrow_down:
...mponents/internal/models/v1/form/FormTabsImpl.java	0.00% <0.00%> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	100	100	73

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	100	100	73

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	88	100	100	73

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

Accessibility Violations Found

Id	Impact
label-title-only	serious
landmark-one-main	moderate
region	moderate

@ravise5 see how view adapts to changes in model. Same needs to be done.

This is already incorporated.