aem-core-forms-components

aem-core-forms-components copied to clipboard

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [ ] I have signed the Adobe Open Source CLA.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes and the overall coverage did not decrease.
• [ ] All unit tests pass on CircleCi.
• [ ] I ran all tests locally and they pass.

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	92	73

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	88	100	92	71

Codecov Report

Merging #783 (2648635) into dev (6a30238) will decrease coverage by 1.84%. The diff coverage is 0.00%.

:exclamation: Current head 2648635 differs from pull request most recent head f5c3edb. Consider uploading reports for the commit f5c3edb to get more accurate results

@@             Coverage Diff              @@
##                dev     #783      +/-   ##
============================================
- Coverage     80.22%   78.39%   -1.84%     
  Complexity      712      712              
============================================
  Files            87       90       +3     
  Lines          2013     2060      +47     
  Branches        268      277       +9     
============================================
  Hits           1615     1615              
- Misses          250      297      +47     
  Partials        148      148              

Files Changed	Coverage Δ
...s/core/components/internal/form/FormConstants.java	100.00% <ø> (ø)
...components/internal/models/v1/form/ReviewImpl.java	0.00% <0.00%> (ø)
...nts/internal/servlets/ReviewDataSourceServlet.java	0.00% <0.00%> (ø)
...e/cq/forms/core/components/models/form/Review.java	0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	92	73

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	90	100	92	71

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	91	100	92	71

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	92	73

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	89	100	92	71

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	99	100	92	73

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	99	100	92	73

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	88	100	92	71

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	92	73

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	87	100	92	71

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	100	100	73

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	92	100	100	71