serverless-chrome icon indicating copy to clipboard operation
serverless-chrome copied to clipboard

Published 20 hours ago • verified publisher icon adieuadieu

Use docker 18.09.0-ce-tp6

Open mikenz opened this issue 7 years ago • 13 comments

Use a newer version of docker to avoid 8GB file size bug in the current AWS linux package. Addresses #166

mikenz avatar Oct 29 '18 12:10 mikenz

Successfully used to build 72.0.3590.0

mikenz avatar Oct 29 '18 19:10 mikenz

awesome job @mikenz! can't wait :)

eliranhe avatar Nov 04 '18 11:11 eliranhe

@adieuadieu Any chance you can merge this so the automated builds start working again?

Thanks

mikenz avatar Dec 16 '18 22:12 mikenz

@mikenz shouldn't this be changed to v18.09.0

skunkworker avatar Dec 18 '18 08:12 skunkworker

@skunkworker yes. If @adieuadieu is interested in restoring the automated builds I'll happily update the PR.

mikenz avatar Dec 28 '18 11:12 mikenz

Hi @mikenz I tried your branch but I couldn't build chromium. I used /scripts/ec2-build.sh. Could you share your build?

Thanks!

paparga avatar Feb 06 '19 00:02 paparga

@adieuadieu , please can you have a look at this PR? @mikenz has done really amazing work.

kiran-redhat avatar Apr 11 '19 22:04 kiran-redhat

Hi @mikenz. I'm late to the party.

I'm a little worried about the maintainability of the hard-coded docker value here. (The irony—or is it hypocrisy—of that statement is not lost on me..)

Is the root issue here that the docker package contained in yum's repository is outdated, hence the manual install? Would this also be resolved by using a newer version of ubuntu on the EC2 instance?

adieuadieu avatar Nov 21 '19 11:11 adieuadieu

@mikenz I should also add, thank you for your efforts and raising this PR.

adieuadieu avatar Nov 21 '19 11:11 adieuadieu

So without some changes Chrome 75? ( I think it's 75) and above won't build on the older environment as it stands right now. Though I do have a fork that builds using amazonlinux:2.0.20191016.0-with-sources. @adieuadieu is that something that I should create a PR for?

skunkworker avatar Nov 22 '19 08:11 skunkworker

@skunkworker please do create a PR, even if it isn't merged, the rest of the community would benefit from it.

AgDude avatar May 14 '20 13:05 AgDude

@AgDude I've created an PR https://github.com/adieuadieu/serverless-chrome/pull/257

I know it works for sure with Chrome 75 but I haven't touched it in a couple months, I did update all of the dependencies though in order to get it build.

skunkworker avatar May 19 '20 04:05 skunkworker

@AgDude I got chrome 81 built with a more up-to-date branch today. https://github.com/adieuadieu/serverless-chrome/pull/258

skunkworker avatar May 20 '20 03:05 skunkworker