Adrian Taylor

Results 215 comments of Adrian Taylor

> the duplication of build_pod_safe_type_set Good question. How's about a new `api_utils.rs` alongside `api.rs`?

This is looking pretty good now!

Thanks for this! I'm aware that this is a problem with multiple mods in the same linked binary. I'm not yet sure that this is how I want to solve...

> Could you include the filename and line number of the include_cpp! in the hash to fix that? Unfortunately, getting such information out of a `proc_macro::Span` requires nightly, as far...

> Are there any un-mangled names right now? I might be not using some features, but I've got some fairly complex classes being wrapped and the only functions using this...

It's probably simpler than that. No need for a macro. Code in autocxd_engine/src/conversion/codegen_{rs|cpp} literally already writes these files to disk, so it should be a small change to include equivalent...

It feels to me as though the solution here is to fix https://github.com/dtolnay/cxx/issues/850, and probably the way to fix that is unfortunately to make a whole new equivalent to `cxx::SharedPtr`,...

There seem to be three problems here: * Sometimes bindgen correctly emits the templated type as a Rust generic. We weren't handling that correctly; we were passing such types onto...

To be specific on the last point: we are expunging all mention of `std::string` from bindgen output by means of a prelude and a blocklist. So, when we encounter a...

It turns out bindgen does a creditable job of producing bindings for `std::string`. I doubt they truly represent the real layout in memory, and of course they don't represent the...