Anna Henningsen
Anna Henningsen
> Is it expected behavior that assert.deepStrictEqual() would fail to compare arrays defined in two different contexts like this? Yes. Node.js considers the “strict” in “deep strict equal” to mean...
> But it would be nice if there was a deep equality check that sidestepped this cross-context problem. @davidflanagan I agree that that would be nice, but in the end...
@nodejs/dns
Fwiw, I marked this semver-major because it’s a big breaking change to stop using `.pipe()` here – my understanding is that this breaks piping to multiple destinations completely, and even...
> Should this be documented in https://nodejs.org/api/crypto.html#crypto_crypto_constants_1? Yes, but to be fair, `OPENSSL_VERSION_NUMBER` is also not documented. I’m not sure if that was just something that was missed, or intentionally...
@Linkgoron I think a better approach overall would be validating this on the C++ side instead, where the abort occurs in the first place.
Interesting that this timed out in one of the Windows tests … might take me a while to get back to that, but it makes me suspect that there’s a...
@rustyconover To be clear, I’m not opposed to having an option like this in HTTP. However, I’d prefer to have this in `net` first in order not to create a...
@rustyconover Two things… - Does this affect the TCP timeout in any way? My guess is that it doesn’t, but I’d like to be sure. - If your goal is...
@ljharb You may be interested in `workerOnGlobalUncaughtException` in `lib/internal/main/worker_thread.js`, and `serializeError` in `lib/internal/error-serdes.js`? Let me know if you’d like me to look into it. The code is supposed to be...