Anna Henningsen
Anna Henningsen
@romgrk Could it be that you’re thinking about a different V8 commit then? Only changes to `include/` are relevant for Node.js addons. That being said – Node.js addons should generally...
Fwiw, the non-filling is an optimization – I think you can just skip the test in chakracore, if you want.
You can bump the limit, it makes sense that it’s somewhat engine-specific. If ChakraCore’s ArrayBuffers and TypedArrays are larger than V8’s, then this is an expected result.
> This aliasing a backing array through a C++ and JS variable just seems like a terrible idea to me and I was hoping that it was a one off...
Just to make sure it doesn’t get lost, `operator*` should only be `const`, otherwise it kind of circumvents what your approach is trying to achieve :)
> is it possible to create more than one Environment by using the CommonEnvironmentSetup::Create function No. In this case, you will need to create the uv event loop, ArrayBufferAllocator, Isolate,...
I think the only intention here was creating fewer unnecessary objects, so I think it would be completely fine if ChakraCore ignores this.
Oh hi! I didn’t know that this existed. One small thing to note: mongosh has an experimental feature called snippets, for even more seamlessly integrating external packages into mongosh: https://github.com/mongodb-labs/mongosh-snippets...
> > You can run snippet install analyze-schema and then call schema() on collections and cursors: https://github.com/mongodb-labs/mongosh-snippets/tree/main/snippets/analyze-schema > > So `snippet install` installs the module client side, right? Yes, exactly...
Does the perf difference carry over to sync calls as well?