adchsm
Make sure $ is available and keep the slidebars variable global
@gaswirth If you're interested, I've turned slidebars into a WP plugin. It already has this patch included. https://wordpress.org/plugins/off-canvas-sidebars/
If you find any issues with themes, please let me know. (Though please read the installation instructions first :) ). https://wordpress.org/plugins/off-canvas-sidebars/installation/
Awesome, thanks! I've already integrated the patch into the theme I'm working on, but my next project I'll give your plugin a shot! Cheers!
Hey @JoryHogeveen, thanks again for the plugin heads up. Works great! For my purposes, I'd still love to see this PR merged, as it works perfectly and it's easier for me to integrate Slidebars with my themes manually, and I miss being able to install with bower to keep everything up-to-date!
Hi @gaswirth , no problem! As for integration, it's possible to disable the plugin frontend and generate everything within you theme while using the config/setting features from the plugin.
I'm currently busy with a fearture update with a lot more hooks for both PHP and JS. It will also feature a first version of a simple API to echo your sidebars in your theme yourself. Will start on a doc/wiki asap :)
See https://github.com/JoryHogeveen/off-canvas-sidebars/pull/10
Thanks :) If you would like to help testing or have more ideas let me know!
Why this fix is still not applied to latest version of master branch?... It is almost 6 months passed.
Just a quick thanks, I was so close to figuring this out myself, but didn't think to declare the var outside of the function, because I'm a JS noob. I also took the time to re-express slidebars as Slidebars, because jshint told me so when running gulp.
