replace-in-file

replace-in-file copied to clipboard

Coverage decreased (-1.4%) to 98.582% when pulling 4f7f00f815350a420ad2cf9f1f38600290d2e1d7 on akaguny:feature/support-most-of-encodings into ebb3c7df191189fc8d3d7bb43797c91994d75096 on adamreisnz:master.

Sep 24 '20 13:09 coveralls

I am a bit concerned about introducing more dependencies and the extra call to decode the contents first.

Not sure if this is something this library should concern itself with. Is it not possible to convert the file encoding prior to loading them into this package?

Would be good to get some wider feedback on this one, as well as detailed reasoning as to why this is a problem and how this solution solves it.

Sep 28 '20 20:09 adamreisnz

Would be good to get some wider feedback on this one, as well as detailed reasoning as to why this is a problem and how this solution solves it.

support more that nodejs support native (ex: windows-1251)

Not sure if this is something this library should concern itself with. Is it not possible to convert the file encoding prior to loading them into this package?

Have any ideas?

I am a bit concerned about introducing more dependencies and the extra call to decode the contents first.

Yes, but I don't know about another solution to supply this feature

Sep 29 '20 06:09 akaguny

Closing as not wanting to introduce additional 3rd party dependencies to this package, and considering content encoding/decoding to be out of scope for this package.

Oct 27 '23 22:10 adamreisnz