Adafruit_CircuitPython_Bundle icon indicating copy to clipboard operation
Adafruit_CircuitPython_Bundle copied to clipboard

PyPI variants of the libraries have `__version__ = "0.0.0-auto.0"`

Open aivarannamaa opened this issue 4 years ago • 2 comments

It looks like the step of assigning the actual version is skipped for the modules uploaded to PyPI. Problem occurs at least with https://pypi.org/project/adafruit-circuitpython-framebuf/#files but I believe I've seen this with other libraries as well.

aivarannamaa avatar Jul 14 '21 19:07 aivarannamaa

This has been fixed for newly created libraries (when created using cookiecutter) and there is a pending PR (https://github.com/adafruit/cookiecutter-adafruit-circuitpython/pull/146) to improve it.

So far, there has been no push to go through the libraries and make the changes to existing libraries. This will hopefully happen after that PR is merged and an adabot patch script can be created to make the changes to all the libraries at once.

lesamouraipourpre avatar Aug 09 '21 09:08 lesamouraipourpre

Just want to bump this as something we might want to roll out to all libs now that it's been in cookiecutter for awhile @kattni

jepler avatar Jun 08 '22 11:06 jepler

Now patched! PyPI variants now have the correct tag version!

tekktrik avatar Aug 25 '22 17:08 tekktrik

Yay!

dhalbert avatar Aug 25 '22 18:08 dhalbert