JSONAce icon indicating copy to clipboard operation
JSONAce copied to clipboard

Could the search display the number of matches found?

Open UrsaDK opened this issue 10 years ago • 3 comments

Not a bug, but more of a feature request...

It would be really handy if the new search introduced in v1.7 (which is absolutely awesome and beats the pants off the default search!!) could display the number of matches found as well as the count of the currently highlighted item. There appears to be enough space at the top-left corner of the search box to put something like: 1 of 6 matches or Not found, which would keep it consistent with the reporting used by the default search.

UrsaDK avatar Jun 10 '15 09:06 UrsaDK

This will take me more time than the last fix :grin:. The editor JSONace uses is https://github.com/ajaxorg/ace if you want check their repo out, if you find how to do it I'll gladly accept the PR.

acrogenesis avatar Jun 10 '15 14:06 acrogenesis

I've opened an issue over there https://github.com/ajaxorg/ace/issues/2539

acrogenesis avatar Jun 10 '15 14:06 acrogenesis

Thanks @acrogenesis! :) Unfortunate, I'm a bit swamped with work at the moment so the likelihood of me finding the time to fiddle with ace is a bit slim, so let's hope ajaxorg guys respond to the issue you've opened!

PS: … but just in case I do find the time to play with ace, I most certainly will send you a PR! :)

UrsaDK avatar Jun 11 '15 09:06 UrsaDK