gevent-socketio icon indicating copy to clipboard operation
gevent-socketio copied to clipboard

SocketIOServer.kill() doesn't release the serving thread

Open gbin opened this issue 13 years ago • 3 comments

Within my app I need to shutdown start/restart gracefully an embedded flask instance.

On the ThreadedWSGIServer counterpart I use shutdown() that works perfectly.

kill() seems to be the equivalent of shutdown() but on SocketIOServer but doesn't work and the serving thread stays in serve_forever

gbin avatar Aug 26 '12 12:08 gbin

I'm not sure if this is related, but on my runserver_socketio dev server (based on that written by django-socketio), I notice that after a number of page refreshes (eg. socket disconnect/reconnects), the new socket connections become increasingly slow to establish. It "feels" like some resource is not being released - I suspected FD leaks, but stale threads would also be plausible. If I kill the server and restart it, the socket connections are fast again... for a while.

dswarbrick avatar Aug 26 '12 16:08 dswarbrick

@gbin @dswarbrick Is this still an issue in master? How do you reproduce it?

sontek avatar Nov 22 '12 21:11 sontek

@dswarbrick @gbin Ping! I want to get this fixed for our next release.

sontek avatar Apr 13 '13 23:04 sontek